Tidied up redundant code in nimservice_webhook.go and nimcache_webhook.go #666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryangorwade
requested review from
ArangoGutierrez,
shengnuo,
shivamerla,
slu2011,
varunrsekar and
visheshtanksale
as code owners
shivamerla
previously approved these changes
Sep 10, 2025
aryangorwade
force-pushed
the
clean-up
branch
from
512dd9b to
f09e4db
Compare
Signed-off-by: Aryan <gorwadearyan@gmail.com>
aryangorwade
force-pushed
the
clean-up
branch
from
275278b to
7310802
Compare
shivamerla
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up duplicate creation and assignment of
newObj.(*appsv1alpha1.NIMService)andnewObj.(*appsv1alpha1.NIMCache)innimservice_webhook.goandnimcache_webhook.go.